introduce CRD to manage MAC addresses used for OVNStaticBridgeMacMappings #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
added a commit
to stuggi/osp-director-dev-tools
that referenced
this pull request
Sep 10, 2021
The HostnameMap index must start with -0 for the role. Right now when <role>-0 node gets removed, the index starts with whatever hostname is. This fixes the HostnameMap index to start with -0.
abays
reviewed
Sep 14, 2021
abays
reviewed
Sep 14, 2021
abays
reviewed
Sep 14, 2021
| return ret | ||
| } | ||
|
|
||
| // IsUniqMAC - check if the hostname is uniq or already present in the reservations |
There was a problem hiding this comment.
Is this checking for hostname or MAC uniqueness?
There was a problem hiding this comment.
No worries, we can change it later if there's even an issue here
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.